-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[basicui] Fix setpoint/slider widgets when %unit% is used in state #1611
Conversation
pattern In OH3.4, getUnitForWidget(Widget w) now returns null when the state pattern contains "%unit%". In that case, the unit must be searched in the item state. Fix openhab#1605 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
3700ac8
to
39f5d06
Compare
This is a fix on branch 3.4.x to be included in the next 3.4 patch.
It has been tested successfully on my production environment with the following items:
and the following sitemap:
Can someone check what is wrong with the build ? Maybe @wborn or @ghys ? |
Here is a jar for testing the fix (first rename the extension from zip to jar): Use bundle:update to update your org.openhab.ui.basic bundle with this jar. |
pattern This is the same fix as openhab#1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
jar testet on my installation - does work for items without state description/pattern as well as items with pattern containing %unit%. |
@lolodomo Please create the PR against the |
pattern This is the same fix as openhab#1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
) This is the same fix as #1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
) This is the same fix as #1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…enhab#1612) This is the same fix as openhab#1611 but for OH 4.0 main branch. Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
pattern
In OH3.4, getUnitForWidget(Widget w) now returns null when the state pattern contains "%unit%". In that case, the unit must be searched in the item state.
Fix #1605
Signed-off-by: Laurent Garnier lg.hc@free.fr